Re: [PATCH] iio: dac: lpc18xx: Use devm_platform_ioremap_resource

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2019-10-13 at 18:14 +0100, jic23@xxxxxxxxxx wrote:
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> 
> Reduce boilerplate.
> Suggested by coccinelle
>   CHECK   drivers/iio/dac/lpc18xx_dac.c
> drivers/iio/dac/lpc18xx_dac.c:121:1-10: WARNING: Use
> devm_platform_ioremap_resource for dac -> base
> 

Reviewed-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> CC: Joachim Eastwood <manabian@xxxxxxxxx>
> ---
>  drivers/iio/dac/lpc18xx_dac.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/dac/lpc18xx_dac.c
> b/drivers/iio/dac/lpc18xx_dac.c
> index 883e84e96609..0ab357bd3633 100644
> --- a/drivers/iio/dac/lpc18xx_dac.c
> +++ b/drivers/iio/dac/lpc18xx_dac.c
> @@ -106,7 +106,6 @@ static int lpc18xx_dac_probe(struct platform_device
> *pdev)
>  {
>  	struct iio_dev *indio_dev;
>  	struct lpc18xx_dac *dac;
> -	struct resource *res;
>  	int ret;
>  
>  	indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*dac));
> @@ -117,8 +116,7 @@ static int lpc18xx_dac_probe(struct platform_device
> *pdev)
>  	dac = iio_priv(indio_dev);
>  	mutex_init(&dac->lock);
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	dac->base = devm_ioremap_resource(&pdev->dev, res);
> +	dac->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(dac->base))
>  		return PTR_ERR(dac->base);
>  




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux