On Thu, 2019-09-12 at 16:43 +0200, Andrea Merello wrote:
> [External]
>
> This patch series fixes ad7949 driver incorrectly read data, simplify the
> code, and enforces device timing constraints.
>
> This has been tested on a UltraZed SOM + a custom carrier equipped with
> several AD7689 A/Ds. Patches have been developed on a Xilinx upstream
> kernel and then rebased on linux-next kernel.
>
Hey,
Thanks for the patches.
Added Charles-Antoine to also take a look.
Apologies for not thinking of adding him sooner.
I typically try to review changes for ADI parts, but he wrote it, so he may have more input than I do.
Jonathan will likely also take a look.
If it's agreed, I would say to at least take the first patch ("iio: ad7949: kill pointless "readback"-handling code")
now and see about the rest.
The rest are a bit more open to discussion, so a v2 may happen.
Thanks
Alex
> Andrea Merello (4):
> iio: ad7949: kill pointless "readback"-handling code
> iio: ad7949: fix incorrect SPI xfer len
> iio: ad7949: fix SPI xfer delays
> iio: ad7949: fix channels mixups
>
> drivers/iio/adc/ad7949.c | 64 +++++++++++++---------------------------
> 1 file changed, 21 insertions(+), 43 deletions(-)
>
> --
> 2.17.1
