On Tue, 3 Sep 2019 07:22:20 +0200 Martin Kepplinger <martink@xxxxxxxxx> wrote: > On 01.09.19 16:50, Jonathan Cameron wrote: > > [...] > > > > > Rather than messing around with a pull request that has already gone > > to Greg, I'm going to leave this as it is for now. > > > > The trace doesn't make a lot of sense to me and whilst a bit messy (as fixed > > up by Lorenzo's follow up) I can't see why things would crash. > > > > So needs debugging and that isn't a problem given we are only looking > > at putting this support into rc1. Not ideal, but there is time > > to work out what is wrong and fix it up! > > > > Thanks, > > > > Jonathan > > > > for the record, I found the problem I've had here. It's been introduced > with the DEV_NAME change and I sent a fix (and question): > > https://lore.kernel.org/linux-iio/20190903051802.22716-1-martin.kepplinger@xxxxxxx/T/#u > Doh. This one is entirely my fault as I messed up that last minute edit :( Greg, this bug is in my outstanding pull request. If you would prefer to pick it from lore and add my Acked-by that's great. If not I can send this after rc1. Thanks, Jonathan
