On Thu, Nov 22, 2018 at 8:52 AM Nicholas Mc Guire <hofrat@xxxxxxxxx> wrote: > > devm_kasprintf() may return NULL on failure of internal allocation thus > the assignments to init.name are not safe if not checked. On error > meson_sar_adc_clk_init() returns negative values so -ENOMEM in the > (unlikely) failure case of devm_kasprintf() should be fine here. > > Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx> > Fixes: 3adbf3427330 ("iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs") Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> thank you for the patch! I tested the non-error case on my Odroid-C1 and it still works fine. Regards Martin