On Fri, 16 Nov 2018 18:13:38 +0000
Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On Mon, 12 Nov 2018 14:11:25 -0800
> Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
>
> > The node has a reg property, therefore its name should include a unit
> > address. Also change the name from 'usb_id_nopull' to 'adc-chan', which
> > is the preferred name for ADC channel nodes.
> >
> > Include headers for constants used in the example.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Looks good to me. I'd just like to leave it a little longer
> to give Rob or other device tree specialists a change
> to take one last look at it.
>
> Ping me if I seem to have forgotten about it!
>
Ah, I should have read on. Already queued. That's fine with me.
Jonathan
> Thanks,
>
> Jonathan
> > ---
> > Changes in v6:
> > - changed node name to adc-chan@
> > - added includes for constants used in the example
> > - updated commit message
> > - added 'Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>' tag
> >
> > Changes in v5:
> > - patch added to the series
> > ---
> > .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> > index b3c86f4ac7cdb..c81993f8d8c39 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> > @@ -140,6 +140,10 @@ VADC_GND_REF and VADC_VDD_VADC.
> >
> > Example:
> >
> > +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> > +#include <linux/irq.h>
> > +/* ... */
> > +
> > /* VADC node */
> > pmic_vadc: vadc@3100 {
> > compatible = "qcom,spmi-vadc";
> > @@ -151,7 +155,7 @@ Example:
> > io-channel-ranges;
> >
> > /* Channel node */
> > - usb_id_nopull {
> > + adc-chan@VADC_LR_MUX10_USB_ID {
> > reg = <VADC_LR_MUX10_USB_ID>;
> > qcom,decimation = <512>;
> > qcom,ratiometric;
>
