On lis 11, 2018 17:04, Jonathan Cameron wrote: > On Sun, 11 Nov 2018 16:59:11 +0100 > Slawomir Stepien <sst@xxxxxxxxx> wrote: > > > devm_* APIs are device managed and make code simpler. > > > > Signed-off-by: Slawomir Stepien <sst@xxxxxxxxx> > Hi Slawomir, > > I made the minor mod below to align this with the change I made in patch 1. > It does close a very small window where you might unnecessary power down > if the first command in the chain_setup function resulted in an error > so the reset may never have been issued. Of course you can't actually > tell where the error occurred in that spi write. We'll just take > the view it's such a minor risk that we can assume the spi write has > no side effects on failure. Got your point here. Checked the final change and it looks OK. Thank you for changing that and picking it. > Thanks for persisting with this. It looks like a good result to me. Thank you for the persisting reviews ;) -- Slawomir Stepien
