On Thu, 1 Nov 2018 15:20:55 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@xxxxxxxxxx> wrote:
This looks wrong. I admit this was done in the same way in the probe function, but that looks a bit wrong as well. Typically, the return value of `regulator_get_voltage()` would get checked with: ret = regulator_get_voltage(st->reg); if (ret < 0) return ret; *val = ret / 1000; So, negative values are errors and zero & positive values are valid voltage values.
I see. So -EINVAL is only used when sent the wrong info type?
