On Mon, 2018-08-27 at 18:13 +0100, Jonathan Cameron wrote: > On Sat, 25 Aug 2018 22:19:08 +0100 > Afonso Bordado <afonsobordado@xxxxxx> wrote: > > > This patch adds device tree support for the fxas21002c driver, > > including > > bindings. > > > > Signed-off-by: Afonso Bordado <afonsobordado@xxxxxx> > > Now, the devicetree bindings should not reflect just what the driver > uses right now, but rather describe the hardware. > > There are interrupts on there for starters that definitely want to be > described from the start. Also there is a reset line that should > probably > be here from the start. > > Potentially also the two power supplies though that's less critical > (nice to have though) > > It is also an i2c and spi part though that can probably be added > later as > we can argue we are only documenting the bindings for the device in > i2c mode > for now. > > So what is here is fine, but I think we need to describe more. > > It's all well understood details of how it is connected so no need to > have tested it with a driver to be sure it will be right. > > Jonathan Ok, so i'm thinking about adding both interrupts, the reset line and the regulators. If i say they are optional in the device tree document, i shouldn't need to add any more code immediately and could just implement support for it later right?
