Magic numbers can be difficult to understand, and at times hide bugs that would otherwise be obvious to readers of the source code. The first patch in this patchset provides a fix for an improperly selected magic number (an off-by-one error). The second patch adds defines to remove these magic numbers and thus help make the driver source code easier to read and debug. The discovery of the error fixed by the first patch is thanks to these defines: the improper magic number stuck out like a sore thumb next to the expected define symbol. So I should have used these defines from the start. William Breathitt Gray (2): iio: 104-quad-8: Fix off-by-one error in register selection iio: 104-quad-8: Provide defines for magic numbers drivers/iio/counter/104-quad-8.c | 86 ++++++++++++++++++++++---------- 1 file changed, 60 insertions(+), 26 deletions(-) -- 2.17.0 -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
