On Wed, Mar 14, 2018 at 03:12:18PM -0300, Rodrigo Siqueira wrote: > There is some improper error handling for IRQ and device register. This > patch adds a proper verification. The IRQ correction was extracted from > John Syne patches. > > Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@xxxxxxxxx> > Signed-off-by: John Syne <john3909@xxxxxxxxx> > --- > drivers/staging/iio/meter/ade7854.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/meter/ade7854.c b/drivers/staging/iio/meter/ade7854.c > index 09fd8c067738..49cbe365e43d 100644 > --- a/drivers/staging/iio/meter/ade7854.c > +++ b/drivers/staging/iio/meter/ade7854.c > @@ -436,7 +436,7 @@ static int ade7854_initial_setup(struct iio_dev *indio_dev) > > /* Disable IRQ */ > ret = ade7854_set_irq(dev, false); > - if (ret) { > + if (ret < 0) { > dev_err(dev, "disable irq failed"); > goto err_ret; > } Why is the original wrong? It seems fine. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html