On Tue, 30 Jan 2018 18:33:43 +0000 Jonathan Cameron <jic23@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, 30 Jan 2018 20:08:19 +0200 > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > On Tue, Jan 30, 2018 at 7:38 PM, Andy Shevchenko > > <andy.shevchenko@xxxxxxxxx> wrote: > > > On Tue, Jan 30, 2018 at 7:25 PM, Steve Presser <steve@xxxxxxxxxxxxx> wrote: > > >> Andy, > > >> > > >> Where did the assertion the second device is a magnetometer come from? Just > > >> the data sheet? > > > > > > Yep. See chapter 8.2. Isn't enough proof? Or you believe in two > > > accelerometers with off-by-one conflicting address on a cheap laptop > > > with left unused two magnetometers on the same time? > > > > > > And we have a driver for magnetometer separately. > > > > > > So, it looks like we need to move ACPI ID to a new "kinda I2C mfd" IIO > > > driver under drivers/iio/imu/bmc150_i2c.c > > > > Even Kconfig for one of the driver states so. > > > > Looking more to it, I think the patch should be reverted and new > > driver is created instead. > > Whilst the question is still open I have dropped the patch. > Was not yet in a non rebasing tree (just in a build test one) > so fine to drop it. Should have said this isn't the final decision or anything, but whilst there are open questions we should take the time to sure of the answer! > > > > > I'm on it. > > > > >> Steve > > >> > > >> > > >> On Tue, Jan 30, 2018, 12:05 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > >> wrote: > > >>> > > >>> On Tue, Jan 30, 2018 at 6:40 PM, Andy Shevchenko > > >>> <andy.shevchenko@xxxxxxxxx> wrote: > > >>> > On Tue, Jan 30, 2018 at 6:01 PM, Jonathan Cameron > > >>> > <Jonathan.Cameron@xxxxxxxxxx> wrote: > > >>> >> On Mon, 29 Jan 2018 16:07:02 +0200 > > >>> >> Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > >>> > > > >>> >>> > But that would take much longer. Feel free to propose it and a > > >>> >>> > patch > > >>> >>> > removing the ifdef fun if you like! > > >>> > > > >>> >>> Where can I see the patch? > > >>> > > > >>> >> Doh. I clearly forgot to push out. Should be able to push to > > >>> >> iio.git on kernel.org later. > > >>> > > > >>> > Thanks, I can see it now. > > >>> > > > >>> > This patch almost wrong. Not by functionality it brings, but by style. > > >>> > > >>> Oy vey, the second device is *not* accelerometer, it is a magnetometer > > >>> [1]. > > >>> > > >>> [1]: https://www.mouser.com/ds/2/783/BST-BMC150-DS000-04-786477.pdf > > >>> > > >>> > I'll send soon a series of fixes to the driver (compile tested only) > > >>> > to provide my view on the matters. > > >>> > > > >>> > P.S. In the future (I have some kind of deja vu I have told this > > >>> > already to someone), please, Cc one or more of Rafael, Mika and/or me > > >>> > for ACPI matters. > > >>> > > >>> -- > > >>> With Best Regards, > > >>> Andy Shevchenko > > > > > > > > > > > > -- > > > With Best Regards, > > > Andy Shevchenko > > > > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
