On 21/01/2018 20:11, Jonathan Cameron wrote:
On Wed, 17 Jan 2018 09:46:23 +0800
Phil Reid <preid@xxxxxxxxxxxxxxxxx> wrote:
G'day Lars-Peter,
On 17/01/2018 01:01, Lars-Peter Clausen wrote:
On 01/16/2018 10:49 AM, Phil Reid wrote:
Add implementation for Analog Devices AD5272 and AD5274 digital
potentiometer devices.
Signed-off-by: Phil Reid <preid@xxxxxxxxxxxxxxxxx>
Hi,
Thanks for the patch. Looks mostly good.
diff --git a/drivers/iio/potentiometer/ad5272.c b/drivers/iio/potentiometer/ad5272.c
new file mode 100644
index 0000000..a04b018
--- /dev/null
+++ b/drivers/iio/potentiometer/ad5272.c
@@ -0,0 +1,227 @@
+/*
+ * Analog Devices AD5372 digital potentiometer driver
+ * Copyright (C) 2018 Phil Reid <preid@xxxxxxxxxxxxxxxxx>
+ *
+ * Datasheet: http://www.analog.com/media/en/technical-documentation/data-sheets/AD5272_5274.pdf
+ *
+ * DEVID #Wipers #Positions Resistor Opts (kOhm) i2c address
+ * ad5272 1 1024 20, 50, 100 01011xx
+ * ad5274 1 256 20, 100 01011xx
+ *
+ * SPDX-License-Identifier: GPL-2.0+
People will probably complain about this, there are some weired rules where
and how the SPDX identifier should be.
Jonathan suggested this in his review of v1. Forgot to mention that in the change list.
Lars is referring to the 'where' element of using SPDX tags. They go
on as a c++ style comment right at the top of the file.
Good think he noticed as I missed this when reviewing v3!
fair enough.
I did grep the kernel and found a mixture of placements so just picked the wrong one.
I also didn't find anything in the Documentation folder about it.
But my tree isn't at the bleeding edge.
--
Regards
Phil Reid
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
