On Tue, 2018-01-16 at 10:46 +0000, Jonathan Cameron wrote:
> On Tue, 16 Jan 2018 12:04:37 +0200
> <alexandru.ardelean@xxxxxxxxxx> wrote:
>
> > From: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
> >
>
> Firstly, even a change to a description makes this a V2 patch
> not a resend. Resends should be identical and only occur if
> either:
> 1) Someone asks you to resend for some reason (wrong cc's perhaps)
> 2) It has been a long time since anyone responded and looks like
> your series has been forgotten.
Ack.
Thanks for the clarification.
Will send it as V2.
>
> > According to the datasheet for all ad719x ADCs,
> > the burnout currents can be enabled only if buffer is enabled
> > and CHOP is disabled.
> >
> > So, if neither of these conditions are met, then
> > we should disable the burnout currents in the driver as well,
> > and warn the user.
> >
> > This change doesn't fix anything.
> > The burnout currents simply won't work if CHOP is enabled
> > or buffer is disabled.
> > The intent is to provide the user with some feedback
> > instead of silently not working inside the chip.
> >
> > This is especially useful when considering device-tree
> > support (and/or device-tree overlays) at a later point,
> > which will allow for a quicker/simpler reconfiguration
> > of the chip settings.
> >
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
>
> Thanks, much better description. I'll pick this up when I'm next
> on the correct PC (possibly not until the weekend).
>
> Jonathan
>
> > ---
> > drivers/staging/iio/adc/ad7192.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/staging/iio/adc/ad7192.c
> > b/drivers/staging/iio/adc/ad7192.c
> > index d11c6de9c777..7f204013d6d4 100644
> > --- a/drivers/staging/iio/adc/ad7192.c
> > +++ b/drivers/staging/iio/adc/ad7192.c
> > @@ -266,6 +266,12 @@ static int ad7192_setup(struct ad7192_state
> > *st,
> >
> > st->conf = AD7192_CONF_GAIN(0);
> >
> > + if (pdata->burnout_curr_en && (!pdata->buf_en || pdata-
> > >chop_en)) {
> > + pdata->burnout_curr_en = false;
> > + dev_warn(dev,
> > + "Can't enable burnout currents: see CHOP
> > or buffer\n");
> > + }
> > +
> > if (pdata->rej60_en)
> > st->mode |= AD7192_MODE_REJ60;
> >
>
> ��.n��������+%������w��{.n�����{��(��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
