Re: [PATCH] iio: accel: mma8452: Bugfix to enbale and allow different events to work parallely.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch fixes by detaching the event related information from
chip_info struct,
and based on channel type and event direction the corresponding
event configuration registers
are picked dynamically. Hence multiple events can be handled in
read/write callbacks.
which chip can have which event(s)?
I am planning to add 'supported events' field in

struct mma_chip_info which indicates which chip can have which events.
During initialization in 'mma_chip_info_table' would set this
'supported events' field for each chip.
But I wonder should I add those changes as part of this patch?
is it necessary or can it be documentation?
I think its not necessary as we only have Freefall and Transient events for now.
Ok I will just update the documentation.

And this patch should have been called "v2". please include a persistent version history to v3 of this patch.
Sure I will send v3 patch, should I use '--in-reply-to' option of git send-email to send v3 patch as reply to
original thread?

On 08/17/2017 07:24 AM, Martin Kepplinger wrote:
This patch fixes by detaching the event related information from
chip_info struct,
and based on channel type and event direction the corresponding
event configuration registers
are picked dynamically. Hence multiple events can be handled in
read/write callbacks.
which chip can have which event(s)?
I am planning to add 'supported events' field in

struct mma_chip_info which indicates which chip can have which events.
During initialization in 'mma_chip_info_table' would set this
'supported events' field for each chip.
But I wonder should I add those changes as part of this patch?
is it necessary or can it be documentation?

And this patch should have been called "v2". please include a persistent version history to v3 of this patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux