On Wed, 9 Aug 2017 18:44:26 +0200 Ladislav Michl <ladis@xxxxxxxxxxxxxx> wrote: > Hello Jonathan, > > On Wed, Aug 09, 2017 at 03:11:00PM +0100, Jonathan Cameron wrote: > > On Tue, 1 Aug 2017 10:26:46 +0200 > > Ladislav Michl <ladis@xxxxxxxxxxxxxx> wrote: > > > > > Generate attributes dynamically based on actual values used > > > by driver - leads to slightly smaller code (on ARM and X64) > > > Scale and sampling frequency definitions are at one place now. > > > > > > Signed-off-by: Ladislav Michl <ladis@xxxxxxxxxxxxxx> > > Sorry, for the small gain I am unconvinced. If this was a new > > driver and it had been submitted this way I wouldn't be asking > > for it to be changed, but I'm also not interested in the churn and > > additional code for what must be a pretty small chance. > > As stated in cover letter I was not really considering it to be > a huge improvement and in fact did it as excercise to better > uderstand iio, so I'm not afraid it doesn't go in. Ooops. The fact I don't always read cover letters becomes apparent ;) Reviewers are lazy, put comments about a particular patch in that patch then there is a slightly larger chance that people will notice it. > > > Also if you really want to do tinification patches, please post > > the actual sizes of the various regions. In particular you need > > to generally have a fairly large saving to justify replacing > > stuff that is constant with code. > > I'll see if something better can be done based on fixes-togreg branch. Cool. > > Thank you, > ladis -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
