On 8.8.2017 17:52, Joe Perches wrote: > On Tue, 2017-08-08 at 14:04 +0200, Michal Simek wrote: >> From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xxxxxxxxxx> > [] >> diff --git a/drivers/iio/adc/xilinx-xadc.h b/drivers/iio/adc/xilinx-xadc.h > [] >> @@ -76,7 +76,7 @@ struct xadc_ops { >> int (*setup)(struct platform_device *pdev, struct iio_dev *indio_dev, >> int irq); >> void (*update_alarm)(struct xadc *, unsigned int); >> - unsigned long (*get_dclk_rate)(struct xadc *); >> + unsigned long (*get_dclk_rate)(struct xadc *xadc); >> irqreturn_t (*interrupt_handler)(int, void *); > > Doesn't it seem odd to you that the lines above and below > have the same form? > > checkpatch is an imperfect tool. > It will always be imperfect. > Please use your eyes and mind too. You are right. I have missed that in internal review. Fixed in v2. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html