On Sun, 2017-07-30 at 14:31 +0100, Jonathan Cameron wrote: > On Sat, 29 Jul 2017 20:27:13 -0500 > David Lechner <david@xxxxxxxxxxxxxx> wrote: > Thanks for review! My answers below. > > On 07/28/2017 05:20 PM, Andy Shevchenko wrote: > > > ACPI enabled platforms do not have a mean of regulators. Instead > > > we use > > > hard coded voltage value for reference pin. When value is 0 > > > (default) we > > > fall back to request a regulator. > > > +/* > > > + * In case of ACPI, we use the 5000 mV as default for the > > > reference pin. > > > + * Device tree users encode that via the vref-supply regulator. > > > + */ > > > +#define TI_ADS7950_VA_MV_ACPI_DEFAULT 5000 > > > > Now that I've thought about it a bit, you don't need to call this > > the > > ACPI default, just call it the default. Then it will be obvious > > that > > this is used when you don't have a regulator. OK. > > > + /* Use hard coded value for reference voltage in ACPI > > > case */ > > > + if (ACPI_COMPANION(&spi->dev)) > > > + st->vref_mv = TI_ADS7950_VA_MV_ACPI_DEFAULT; > > > > Instead of checking or ACPI, you could just say "if we have a dummy > > regulator, then use the default value". > Agreed. Sounds sensible to me. Hopefully in DT people will > provide the right regulator, but chances are this won't > always happen. There is no call like regulator_is_dummy() (and, looking into the code of regulator framework, can't be) Can you elaborate a bit, maybe I'm missing something obvious? -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
