Thanks for doing that work. I have had it on my list for a long time and you seem to fix it. Although I'd happily review and possibly test it, unfortunately I can't do so before the week of August 21st.
If this might go in quick, nothing will stop me from reviewing either, so, whatever. Thanks again!
Sure no problem, looking forward to your review comments.
Actually I am planning to add Orientation events for FXLS8471Q, for
that is it good idea to overload existing
IIO_ROT channel type? Also thinking of adding 4 channel modifiers i.e
portrait up/down, landscape left/right.
Any suggestions are welcome. Thank you.
On 07/31/2017 10:17 PM, harinath Nampally wrote:
This driver supports multiple devices like mma8653, mma8652, mma8452,
mma8453 and
fxls8471. Almost all these devices have more than one event. Current
driver design
hardcodes the event specific information, so only one event can be
supported by this
driver and current design doesn't have the flexibility to add more
events.
This patch fixes by detaching the event related information from
chip_info struct,
and based on channel type and event direction the corresponding event
configuration registers
are picked dynamically. Hence multiple events can be handled in
read/write callbacks.
Changes are thoroughly tested on fxls8471 device on imx6UL Eval board
using iio_event_monitor user space program.
After this fix both Freefall and Transient events are handled by the
driver without any conflicts.
Thanks for doing that work. I have had it on my list for a long time and you seem to fix it. Although I'd happily review and possibly test it, unfortunately I can't do so before the week of August 21st.
If this might go in quick, nothing will stop me from reviewing either, so, whatever. Thanks again!
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
