Re: [PATCH] iio: adc: ad7766: Remove unneeded gpiod NULL check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 16 Jul 2017 18:26:03 -0300
Fabio Estevam <festevam@xxxxxxxxx> wrote:

> From: Fabio Estevam <fabio.estevam@xxxxxxx>
> 
> The gpiod API checks for NULL descriptors, so there is no need to
> duplicate the check in the driver.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/ad7766.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7766.c b/drivers/iio/adc/ad7766.c
> index 75cca42..ce45037 100644
> --- a/drivers/iio/adc/ad7766.c
> +++ b/drivers/iio/adc/ad7766.c
> @@ -103,8 +103,7 @@ static int ad7766_preenable(struct iio_dev *indio_dev)
>  		return ret;
>  	}
>  
> -	if (ad7766->pd_gpio)
> -		gpiod_set_value(ad7766->pd_gpio, 0);
> +	gpiod_set_value(ad7766->pd_gpio, 0);
>  
>  	return 0;
>  }
> @@ -113,8 +112,7 @@ static int ad7766_postdisable(struct iio_dev *indio_dev)
>  {
>  	struct ad7766 *ad7766 = iio_priv(indio_dev);
>  
> -	if (ad7766->pd_gpio)
> -		gpiod_set_value(ad7766->pd_gpio, 1);
> +	gpiod_set_value(ad7766->pd_gpio, 1);
>  
>  	/*
>  	 * The PD pin is synchronous to the clock, so give it some time to

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux