On 05/03/2017 10:43 AM, Andy Shevchenko wrote: >>>>>> + .owner = THIS_MODULE, >>>>> >>>>> This is redundant I'm pretty sure. >>>> >>>> Even in 2017, drivers keep being added that carry such assignments. Can >>>> you explain when it is needed and when not? Otherwise, I will leave it in. >>> >>> The above I'm 100% sure is not needed. It's needed only in cases when >>> framework / device core doesn't do this for ya. >>> >>> In the above case IIRC device core does it once for all. > >> Then this is not consistently filtered out in new driver reviews. I can >> remove it, of course. > > Please, remove. > > I guess many of new drivers just lack of proper review :-( > The kbuild bot will even send automated patches to remove the owner field if a patch that has the owner field is merged. So definitely remove it. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
