On 20/08/16 17:47, Marek Vasut wrote:
> On 08/20/2016 05:17 AM, Matt Ranostay wrote:
>> Add support for Texas Instruments ADC141S626, and ADC161S626 chips.
>
> Hi,
>
> [...]
>
>> +++ b/Documentation/devicetree/bindings/iio/adc/ti-adc161s626.txt
>> @@ -0,0 +1,17 @@
>> +* Texas Instruments ADC141S626, and ADC161S626 chip
>
> I think you should drop the comma and use plural (chips) here.
>
>> +Required properties:
>> + - compatible: Should be "ti,adc141s626" or "ti,adc161s626"
>> + - reg: spi chip select number for the device
>> +
>> +Recommended properties:
>> + - spi-max-frequency: Definition as per
>> + Documentation/devicetree/bindings/spi/spi-bus.txt
>> +
>> +Example:
>> +adc@0 {
>> + compatible = "ti,adc161s626";
>> + reg = <0>;
>> + spi-max-frequency = <4300000>;
>> +};
>> +
>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>> index 1de31bdd4ce4..2658f2f69bad 100644
>> --- a/drivers/iio/adc/Kconfig
>> +++ b/drivers/iio/adc/Kconfig
>> @@ -426,6 +426,18 @@ config TI_ADC128S052
>> This driver can also be built as a module. If so, the module will be
>> called ti-adc128s052.
>>
>> +config TI_ADC161S626
>> + tristate "Texas Instruments ADC161S626 1-channel differential ADC"
>> + depends on SPI
>> + select IIO_BUFFER
>> + select IIO_TRIGGERED_BUFFER
>> + help
>> + If you say yes here you get support for Texas Instruments ADC141S626,
>> + and ADC161S626 chips.
>> +
>> + This driver can also be build
>
> ... be built ... :-)
>
>> as a module. If so, the module will be
>> + called ti-adc161s626.
>> +
>> config TI_ADS1015
>> tristate "Texas Instruments ADS1015 ADC"
>> depends on I2C && !SENSORS_ADS1015
>
> The code looks OK.
>
Agreed - I fixed the above up and applied to the togreg branch of iio.git.
This is a good little driver in it's own right. No need to wait
for the consumer you have for it Matt to be ready!
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
