Re: [PATCH] iio: chemical: ams-iaq-core: update driver name and DT match table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 3, 2016 at 1:08 PM, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
> On 08/03/2016 10:02 PM, Matt Ranostay wrote:
>> On Wed, Aug 3, 2016 at 5:13 AM, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
>>> On 08/02/2016 06:25 AM, Matt Ranostay wrote:
>>>> DT match name should be similar to the i2c device table entry.
>>>
>>> Why?
>>
>> To be consistent mostly.   But I have noticed  compatible =
>> "ams,iaq-core" doesn't actually match...
>
> Well, consistent with what? The normal pattern for devicetree compatible
> strings is vendor,partname. So that would suggest that ams,iaq-core is the
> preferred solution if it is supposed to be consistent. Btw. there seem to be
> no binding documents for this part.
>
>> Does anyone here know if i2c-core just checks the id_table, and not
>> of_match_table as well?
>>
>> Anyone have thoughts on this but I dig into this too deep?
>
> It uses of_match_table when it is set. See
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/i2c/i2c-core.c#n609

Yeah thought would enumerate it as well.. but could be that someone
broke something in i2c controller or core. Will test again :)

>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux