On Thu, Jul 28, 2016 at 12:17 AM, Matt Ranostay <mranostay@xxxxxxxxx> wrote:
> On Wed, Jul 27, 2016 at 1:29 PM, Giorgio <giorgio.nicole@xxxxxxxx> wrote:
>> Hi,
>>
>> I noticed a trivial bug in the file 'drivers/iio/adc/ti-ads1015.c', in
>> the function:
>>
>> static int ads1015_get_channels_config_of(struct i2c_client *client)
>> {
>> struct ads1015_data *data = i2c_get_clientdata(client);
>> struct device_node *node;
>> ...
>>
>> The pointer 'data' is not correctly assigned; its definition should look
>> like:
>>
>> struct iio_dev *indio_dev = i2c_get_clientdata(client);
>> struct ads1015_data *data = iio_priv(indio_dev);
>>
>
> Good catch however it seems ads1015_data pointer reference isn't even
> needed in this function.
> I'll submit a patchset to remove this and cc you.
>
> Thanks,
>
Was looking at the hwmon driver :). But yes this is incorrect and
should be fixed in iio
> Matt
>
>> as is the case in:
>>
>> static void ads1015_get_channels_config(struct i2c_client *client)
>> {
>> ..
>>
>> giorgio
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
