Re: trivial error in ti-ads1015.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 27, 2016 at 1:29 PM, Giorgio <giorgio.nicole@xxxxxxxx> wrote:
> Hi,
>
> I noticed a trivial bug in the file 'drivers/iio/adc/ti-ads1015.c', in
> the function:
>
> static int ads1015_get_channels_config_of(struct i2c_client *client)
> {
>         struct ads1015_data *data = i2c_get_clientdata(client);
>         struct device_node *node;
> ...
>
> The pointer 'data' is not correctly assigned; its definition should look
> like:
>
>         struct iio_dev *indio_dev = i2c_get_clientdata(client);
>         struct ads1015_data *data = iio_priv(indio_dev);
>

Good catch however it seems ads1015_data pointer reference isn't even
needed in this function.
I'll submit a patchset to remove this and cc you.

Thanks,

Matt

> as is the case in:
>
> static void ads1015_get_channels_config(struct i2c_client *client)
> {
> ..
>
> giorgio
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux