Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 21, 2015 at 11:16:11AM +0100, Ludovic Desroches wrote:
> On Mon, Dec 21, 2015 at 10:38:11AM +0100, Peter Meerwald-Stadler wrote:
> > 
> > > This driver supports the new version of the Atmel ADC device introduced
> > > with the SAMA5D2 SoC family.
> > 
> > some minor, quick comments below...
> 
> Thanks for your review
> 

[...]

> > > +static unsigned at91_adc_startup_time(unsigned startup_time_min,
> > > +				      unsigned adc_clk_khz)
> > > +{
> > > +	const unsigned startup_lookup[] = {
> > > +		0,     8,  16,  24,
> > > +		64,   80,  96, 112,
> > > +		512, 576, 640, 704,
> > > +		768, 832, 896, 960
> > > +		};
> > 
> > do we need the ADC_MR_STARTUP_SUT #defines then?
> > 
> 
> Why not.
>

Sorry my answer is not clear! I mean, yes these defines are probably
useless.

[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux