On 19/09/14 09:27, Peter Meerwald wrote: > >>> I'd prefix with SPMI_IADC_ >> >> Is this really necessary? I could prefix it with IADC3, which >> is the subtype of this peripheral. > > I think for a similar driver we are sticking with VADC, so no... This is always a little tricky to decide. We want something to prevent accidental namespace clashes and also to clearly identify device specific constants, but conversely long prefixes are somewhat of a pain. As far as I am concerned IADC is just obscure enough that it is unlikely to ever be used in any subsystem headers and is hence fine.. (ADC would not be!) > >>>> +#define IADC_REVISION2 0x1 >>>> +#define IADC_REVISION2_SUPPORTED_IADC 1 >>>> + >>>> +#define IADC_PERPH_TYPE 0x4 >>>> +#define IADC_PERPH_TYPE_ADC 8 >>>> + >>>> +#define IADC_PERPH_SUBTYPE 0x5 >>>> +#define IADC_PERPH_SUBTYPE_IADC 3 >> >> Rest of the comments will be fixed in next version. > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
