> > I'd prefix with SPMI_IADC_ > > Is this really necessary? I could prefix it with IADC3, which > is the subtype of this peripheral. I think for a similar driver we are sticking with VADC, so no... > > > +#define IADC_REVISION2 0x1 > > > +#define IADC_REVISION2_SUPPORTED_IADC 1 > > > + > > > +#define IADC_PERPH_TYPE 0x4 > > > +#define IADC_PERPH_TYPE_ADC 8 > > > + > > > +#define IADC_PERPH_SUBTYPE 0x5 > > > +#define IADC_PERPH_SUBTYPE_IADC 3 > > Rest of the comments will be fixed in next version. -- Peter Meerwald +43-664-2444418 (mobile) -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
