On Thu, 2014-09-18 at 20:59 +0200, Peter Meerwald wrote: <snip> > I'd prefix with SPMI_IADC_ Is this really necessary? I could prefix it with IADC3, which is the subtype of this peripheral. > > +#define IADC_REVISION2 0x1 > > +#define IADC_REVISION2_SUPPORTED_IADC 1 > > + > > +#define IADC_PERPH_TYPE 0x4 > > +#define IADC_PERPH_TYPE_ADC 8 > > + > > +#define IADC_PERPH_SUBTYPE 0x5 > > +#define IADC_PERPH_SUBTYPE_IADC 3 Rest of the comments will be fixed in next version. Thank you for review. Regards, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html