On 07/08/14 18:30, Jonathan Cameron wrote:
On 29/07/14 10:01, Martin Fuzzey wrote:
The hardware contains a single configurable highpass filter which
is normally used for transient detection (event).
However it is also possible to enable this filter for normal channel
reading. Add a new attribute in_accel_high_pass_filter_en to do this.
Signed-off-by: Martin Fuzzey <mfuzzey@xxxxxxxxxxx>
The obvious answer to this would be to set the cuttoff to 0.
Presumably the complexity here is there is only one high pass filter
implementation, both for the data and for the event?
Yes exactly
If so I would probably still prefer it was done via the 3db point
setting, just that you have two attributes to access that - one for
the channel and one for the event. Setting the channel version to
non zero would change both. Setting the event one to any value
would change both only if the channel version is not zero.
But I don't think that would handle the use case of
* No filter for channel data
* Filter for event
The hardware has
1) A register to set the filter frequency (one of 4 possible values,
with the allowed set depending on the current sampling frequency)
2) A bit to enable the filter for value readings (default disabled)
3) A bit to disable the filter for transient detection (default enabled)
My current patchset does not support 3) - the filter is always enabled
for transient events
It's a little fiddly, perhaps having an enable on a filter is
the way to go... Anyone else have any thought on this?
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
