Acked-by ? I'll take it with the vague agreement but nice to have a formal note of it in git! On July 4, 2014 12:01:25 AM GMT+01:00, Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> wrote: >Thanks for the fix. Agree with the whole series. > >Thanks, >Srinivas > >On 07/02/2014 11:44 PM, Sachin Kamat wrote: >> IIO_CHAN_INFO_SAMP_FREQ and IIO_CHAN_INFO_HYSTERESIS cases ignored >> the actual return values (which could be -EINVAL) and instead >> returned IIO_VAL_INT_PLUS_MICRO always. Return the actual value >> obtained from the functions. Both functions return >IIO_VAL_INT_PLUS_MICRO >> upon success. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxxx> >> Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> >> --- >> drivers/iio/pressure/hid-sensor-press.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/iio/pressure/hid-sensor-press.c >b/drivers/iio/pressure/hid-sensor-press.c >> index 1cd190c..2c0d2a4 100644 >> --- a/drivers/iio/pressure/hid-sensor-press.c >> +++ b/drivers/iio/pressure/hid-sensor-press.c >> @@ -78,7 +78,6 @@ static int press_read_raw(struct iio_dev >*indio_dev, >> struct press_state *press_state = iio_priv(indio_dev); >> int report_id = -1; >> u32 address; >> - int ret; >> int ret_type; >> s32 poll_value; >> >> @@ -128,14 +127,12 @@ static int press_read_raw(struct iio_dev >*indio_dev, >> ret_type = IIO_VAL_INT; >> break; >> case IIO_CHAN_INFO_SAMP_FREQ: >> - ret = hid_sensor_read_samp_freq_value( >> + ret_type = hid_sensor_read_samp_freq_value( >> &press_state->common_attributes, val, val2); >> - ret_type = IIO_VAL_INT_PLUS_MICRO; >> break; >> case IIO_CHAN_INFO_HYSTERESIS: >> - ret = hid_sensor_read_raw_hyst_value( >> + ret_type = hid_sensor_read_raw_hyst_value( >> &press_state->common_attributes, val, val2); >> - ret_type = IIO_VAL_INT_PLUS_MICRO; >> break; >> default: >> ret_type = -EINVAL; -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
