On Sun, Jun 29, 2014 at 12:00:20PM +0100, Jonathan Cameron wrote: > On 21/06/14 20:55, Fabio Estevam wrote: >> On Sat, Jun 21, 2014 at 7:18 AM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote: >>>> + >>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>> >>> Could this not in theory fail? >> >> Yes, but devm_ioremap_resource will take care of it, so we don't need >> to check for error here. > Nothing like counter intuitive behaviour. Ah well. > > Thanks for explaining this! Maybe it would be better to have: mem = platform_ioremap_resource(pdev, IORESOURCE_MEM, 0); which wraps up both the platform_get_resource() call with devm_ioremap_resource() so driver writers don't have to be concerned about this aspect? -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
