From: Jonathan Cameron <jic23@xxxxxxxxxx>
Data: Sunday, March 02, 2014 6:03 AM
>To: linux-iio@xxxxxxxxxxxxxxx
>Cc: Jonathan Cameron; Dan Carpenter; Duan Fugang-B38611
>Subject: [PATCH] iio:adc:vf610 ensure correct handing of interruption of wait
>for completion
>
>Issue highlighted by smatch warning:
>
>CHECK drivers/iio/adc/vf610_adc.c
>drivers/iio/adc/vf610_adc.c:466 vf610_read_raw() warn: unsigned 'ret' is never
>less than zero.
>
>As wait_for_completion_interruptible_timeout can return -ERESTARTSTSYS, if
>interrupted, ret must be signed.
>
>Signed-off-by: Jonathan Cameron <jic23@xxxxxxxxxx>
>Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>Cc: Fugang Duan <B38611@xxxxxxxxxxxxx>
>---
> drivers/iio/adc/vf610_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c index
>37f542e..44799eb5 100644
>--- a/drivers/iio/adc/vf610_adc.c
>+++ b/drivers/iio/adc/vf610_adc.c
>@@ -447,7 +447,7 @@ static int vf610_read_raw(struct iio_dev *indio_dev, {
> struct vf610_adc *info = iio_priv(indio_dev);
> unsigned int hc_cfg;
>- unsigned long ret;
>+ long ret;
>
> switch (mask) {
> case IIO_CHAN_INFO_RAW:
>--
>1.9.0
>
>
Acked-by: Fugang Duan <B38611@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
