On 16/02/14 18:56, Lars-Peter Clausen wrote:
On 02/16/2014 01:19 PM, Hartmut Knaack wrote:
Hi together,
I noticed, that many pointers in the IIO subsystem are checked for successful allocation in the way of "if (pointer == NULL)" or "if (pointer != NULL)", while in a few cases the form of simply "if (!pointer)" or "if (pointer)" is used. So, is there any interest in having a more consistent style, and if so, for which one?
My personal preference is for the latter one.
I think enforcing this is a bit to much nitpicking. So if you clean this up the other pattern will probably appear again in new drivers at some point.
Otherwise, if you feel strongly about this, go ahead and send a patch.
My inclination on this is that there are better things to spend time on
but as they say scratch the itch if you really want to!
I'd rather have the nice error patch cleanups you've been doing or
if you are really bored, there are lots of staging drivers in need of
tendour loving care!
J
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
