From: Jonathan Cameron <jic23@xxxxxxxxxx> Data: Saturday, February 15, 2014 6:29 PM >To: Duan Fugang-B38611 >Cc: shawn.guo@xxxxxxxxxx; sachin.kamat@xxxxxxxxxx; pmeerw@xxxxxxxxxx; >lars@xxxxxxxxxx; mark.rutland@xxxxxxx; linux-iio@xxxxxxxxxxxxxxx >Subject: Re: [PATCH v5 2/3] iio:adc:imx: add Freescale Vybrid vf610 adc driver > >On 15/02/14 10:18, Jonathan Cameron wrote: >> On 26/01/14 05:39, Fugang Duan wrote: >>> Add Freescale Vybrid vf610 adc driver. The driver only support ADC >>> software trigger. >>> >>> VF610 ADC device documentation is available at below reference manual >>> (chapter 37): >>> http://cache.freescale.com/files/32bit/doc/ref_manual/VYBRIDRM.pdf? >>> fpsp=1&WT_TYPE=Reference%20Manuals&WT_VENDOR=FREESCALE&WT_FILE_FORMAT >>> =pdf&WT_ASSET=Documentation >>> >>> CC: Shawn Guo <shawn.guo@xxxxxxxxxx> >>> CC: Jonathan Cameron <jic23@xxxxxxxxxx> >>> CC: Mark Rutland <mark.rutland@xxxxxxx> >>> CC: Otavio Salvador <otavio@xxxxxxxxxxxxxxxx> >>> CC: Peter Meerwald <pmeerw@xxxxxxxxxx> >>> CC: Lars-Peter Clausen <lars@xxxxxxxxxx> >>> Signed-off-by: Fugang Duan <B38611@xxxxxxxxxxxxx> >> >> I very much like the simplified approach you have taken for this >> initial merge. Much easier to start simple and build up to the more >> complex functionality. >> >> There was one missing mutex unlock in an error path (noted below). I have >> fixed that and applied to the togreg branch of iio.git. This will initially >> go out as the testing branch for the autobuilders to play with it. >> >> Also devm_irq requests always make me nervous, but I think this one is >> fine so have left it alone >> >> Jonathan >As an update I also fixed up the build - see below. One day I'll no send out >applied messages until after my local build tests have finished! > >Note that it is this sort of thing that has led me to pushing out a testing >branch as that catches all the weird combinations that I don't. > >>> + >>> +static const struct iio_info vf610_adc_iio_info = { >>> + .driver_module = THIS_MODULE, >>> + .read_raw = &vf610_read_raw, >>> + .write_raw = &vf610_write_raw, >>> + .debugfs_reg_access = &vf610_adc_reg_access, >>> + .attrs = &vf610_attribute_group, }; >>> + >>> +static const struct of_device_id vf610_adc_match[] = { >>> + { .compatible = "fsl,vf610-adc", }, >>> + { /* sentinel */ } >>> +}; >>> +MODULE_DEVICE_TABLE(of, vf610_adc_dt_ids); >Your MODULE_DEVICE_TABLE needs to take a second variable that actually exists... >Also needs to depend in the KCONFIG on OF to avoid build issues on other >platforms. > >I've added both. > Jonathan, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
