On 14/02/14 16:11, Lars-Peter Clausen wrote:
On 02/14/2014 04:16 PM, Denis CIOCCA wrote:
If st_accel_common_probe function fails, the device must be freed.
Added devm_iio_device_free also on common_remove function.
When the device is allocated with devm_iio_device... you do not need to manually free the device. If probe fails the device will be freed automatically.
- Lars
Indeed - the handling in these drivers appears entirely correct.
The allocs are done with devm so under any error conditions or
deliberate removal they will be cleared up.
The register should not be done using devm as that would mean the
unregister would occur late. As the register is done last, there
are no error conditions that can require it being removed in the
probe function. Hence the code looks fine to me as it stands.
So Denis, do you have an observed problem that prompted these patches?
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
