My bad, since a405b00 external reference is supported if the device has
a regulator, and fallback to internal if it doesn't.
Best,
Vivien
----- Mail original -----
> De: "Lars-Peter Clausen" <lars@xxxxxxxxxx>
> À: "Vivien Didelot" <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>
> Cc: "Jonathan Cameron" <jic23@xxxxxxxxxx>, linux-iio@xxxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxxxxxxxx
> Envoyé: Vendredi 10 Janvier 2014 04:27:43
> Objet: Re: max1363: internal reference
>
> On 01/09/2014 06:39 PM, Vivien Didelot wrote:
> > Hi Jonathan,
> >
> > As described in the max1363.c header, the control of the internal
> > reference is not currently supported by the driver.
> >
> > We have two max11603 and max11605 which need this option. We
> > currently
> > use a monkey patch like this in max1363.c:
> >
> > @@ -1414,7 +1414,12 @@ static const struct max1363_chip_info ma
> > static int max1363_initial_setup(struct max1363_state *st)
> > {
> > +#ifdef OUR_BOARD
> > + st->setupbyte = MAX1363_SETUP_AIN3_IS_AIN3_REF_IS_INT
> > +#else
> > st->setupbyte = MAX1363_SETUP_AIN3_IS_AIN3_REF_IS_VDD
> > +#endif
> > | MAX1363_SETUP_POWER_UP_INT_REF
> > | MAX1363_SETUP_INT_CLOCK
> > | MAX1363_SETUP_UNIPOLAR
> >
> > In order to add the support for this, I would suggest adding a
> > platform_data for this driver such as:
> >
> > struct max1363_platform_data {
> > bool internal_reference;
> > };
> >
> > What do you think?
>
> Yes. But make sure to properly document the platform data struct with
> kernel
> doc.
>
> - Lars
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
