Re: [PATCH V2 1/2]staging:iio:ad799x fix error_free_irq, use devm_request_threaded_irq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/02/2014 12:04 AM, Hartmut Knaack wrote:
> Only free an IRQ in error_free_irq, if it has been requested previously.
> 
> Signed-off-by: Hartmut Knaack <knaack.h@xxxxxx>

Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx>

> ---
> diff --git a/drivers/staging/iio/adc/ad799x_core.c b/drivers/staging/iio/adc/ad799x_core.c
> index e32a555..3deb390 100644
> --- a/drivers/staging/iio/adc/ad799x_core.c
> +++ b/drivers/staging/iio/adc/ad799x_core.c
> @@ -590,7 +590,8 @@ static int ad799x_probe(struct i2c_client *client,
>  	return 0;
>  
>  error_free_irq:
> -	free_irq(client->irq, indio_dev);
> +	if (client->irq > 0)
> +		free_irq(client->irq, indio_dev);
>  error_cleanup_ring:
>  	ad799x_ring_cleanup(indio_dev);
>  error_disable_reg:
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux