Re: [PATCH Resend 00/33] iio: Implement and use devm_iio_device_register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jonathan,

On 24 November 2013 00:13, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On 10/29/13 11:39, Sachin Kamat wrote:
>> Resending this series after rebasing onto the latest iio tree.
>> Previous version is available at [1].
>> [1] http://www.spinics.net/lists/linux-iio/msg10682.html
>>
>> * Added tested and reviewed by tags to patch 1. Thank you Lars.
>> * Included a patch (patch2) to re-organise the kernel doc
>>   as suggested by Lars.
>
> Hi Sachin,
>
> Having finaly waded through this whole set I have a few general comments.
> Firstly, I am sorry I am refusing to take so many of these.  I did mention
> in response to an earlier series that I was not keen on applying this
> shortening in code, if there was stuff that should be done after the
> unregister, but which was not.
>
> I have kept to that as I would much rather see those drivers improved by
> adding for example power down of the part on removal of the driver or making
> sure that the removal is in the correct order.  Feel free to try and
> talk me around though!

Thank you for patiently reviewing all the patches and providing your comments.
I agree with your concerns and your decision to have the missing
things implemented
in the drivers first before optimizing them.

> Anyhow, thanks for your hard work on this.

Thanks for your support.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux