On 10/29/13 11:39, Sachin Kamat wrote: > devm_iio_device_register simplifies the code. > > Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> This one is fine. Applied to the togreg branch of iio.git Thanks. > --- > drivers/iio/adc/viperboard_adc.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/iio/adc/viperboard_adc.c b/drivers/iio/adc/viperboard_adc.c > index 09727a7..674b333 100644 > --- a/drivers/iio/adc/viperboard_adc.c > +++ b/drivers/iio/adc/viperboard_adc.c > @@ -139,7 +139,7 @@ static int vprbrd_adc_probe(struct platform_device *pdev) > indio_dev->channels = vprbrd_adc_iio_channels; > indio_dev->num_channels = ARRAY_SIZE(vprbrd_adc_iio_channels); > > - ret = iio_device_register(indio_dev); > + ret = devm_iio_device_register(&pdev->dev, indio_dev); > if (ret) { > dev_err(&pdev->dev, "could not register iio (adc)"); > return ret; > @@ -150,22 +150,12 @@ static int vprbrd_adc_probe(struct platform_device *pdev) > return 0; > } > > -static int vprbrd_adc_remove(struct platform_device *pdev) > -{ > - struct iio_dev *indio_dev = platform_get_drvdata(pdev); > - > - iio_device_unregister(indio_dev); > - > - return 0; > -} > - > static struct platform_driver vprbrd_adc_driver = { > .driver = { > .name = "viperboard-adc", > .owner = THIS_MODULE, > }, > .probe = vprbrd_adc_probe, > - .remove = vprbrd_adc_remove, > }; > > module_platform_driver(vprbrd_adc_driver); > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html