On 10/29/13 11:39, Sachin Kamat wrote:
> devm_iio_device_register simplifies the code.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
Hmm.. Interesting case, but I suspect a bug is hiding in the original driver.
Would definitely expect the unregister to be before the disable_irq.
> ---
> drivers/iio/adc/twl6030-gpadc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index 53e1c64..d1ef33c 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -948,15 +948,12 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
> indio_dev->channels = pdata->iio_channels;
> indio_dev->num_channels = pdata->nchannels;
>
> - return iio_device_register(indio_dev);
> + return devm_iio_device_register(&pdev->dev, indio_dev);
> }
>
> static int twl6030_gpadc_remove(struct platform_device *pdev)
> {
> - struct iio_dev *indio_dev = platform_get_drvdata(pdev);
> -
> twl6030_gpadc_disable_irq(TWL6030_GPADC_RT_SW1_EOC_MASK);
> - iio_device_unregister(indio_dev);
>
> return 0;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
