On 20.03.2025 11:21, David Lechner wrote:
> Move disabling of the SPI offload before attempting to use the SPI bus
> to write a register in ad7380_offload_buffer_predisable().
>
> This caused a crash in the spi_engine_irq() interrupt handler due to
> being in an invalid state.
>
> Fixes: bbeaec81a03e ("iio: ad7380: add support for SPI offload")
> Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
Reviewed-by: Angelo Dureghello <adureghello@xxxxxxxxxxxx>
Thanks.
> ---
> drivers/iio/adc/ad7380.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7380.c b/drivers/iio/adc/ad7380.c
> index 4fcb49fdf56639784098f0147a9faef8dcb6b0f6..a2b41980c942e4cd1575bfe4f3846e297ad5d01d 100644
> --- a/drivers/iio/adc/ad7380.c
> +++ b/drivers/iio/adc/ad7380.c
> @@ -1211,6 +1211,9 @@ static int ad7380_offload_buffer_predisable(struct iio_dev *indio_dev)
> struct ad7380_state *st = iio_priv(indio_dev);
> int ret;
>
> + spi_offload_trigger_disable(st->offload, st->offload_trigger);
> + spi_unoptimize_message(&st->offload_msg);
> +
> if (st->seq) {
> ret = regmap_update_bits(st->regmap,
> AD7380_REG_ADDR_CONFIG1,
> @@ -1222,10 +1225,6 @@ static int ad7380_offload_buffer_predisable(struct iio_dev *indio_dev)
> st->seq = false;
> }
>
> - spi_offload_trigger_disable(st->offload, st->offload_trigger);
> -
> - spi_unoptimize_message(&st->offload_msg);
> -
> return 0;
> }
>
>
> ---
> base-commit: 9f36acefb2621d980734a5bb7d74e0e24e0af166
> change-id: 20250320-iio-adc-ad7380-fix-spi-offload-buffer-predisable-a801dcfb9c00
>
> Best regards,
> --
> David Lechner <dlechner@xxxxxxxxxxxx>
>
