Re: [PATCH v2 3/5] iio: mxs-lradc: add scale attribute to channels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marek,

On 07/19/2013 06:14 PM, Marek Vasut wrote:
Dear Hector Palacios,

Dear Marek,

On 07/19/2013 04:30 PM, Marek Vasut wrote:
@@ -228,39 +230,12 @@ struct mxs_lradc {

   #define LRADC_RESOLUTION			12
   #define LRADC_SINGLE_SAMPLE_MASK		((1 << LRADC_RESOLUTION) - 1)

-/*
- * Raw I/O operations
- */
-static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
+static int mxs_lradc_read_single(struct iio_dev *iio_dev,

   			const struct iio_chan_spec *chan,
   			int *val, int *val2, long m)

   {

   	struct mxs_lradc *lradc = iio_priv(iio_dev);
   	int ret;

-	unsigned long mask;
-
-	if (m != IIO_CHAN_INFO_RAW)
-		return -EINVAL;
-
-	/* Check for invalid channel */
-	if (chan->channel > LRADC_MAX_TOTAL_CHANS)
-		return -EINVAL;

This was already resolved, so this patch won't apply I'm afraid.

You mean the 'unsigned long mask', right?  Yeah, I think I had resolved
that one before submitting, but looks like I didn't.
The other check is not resolved afaik. We agreed to remove it, but on a
different patch.

I mean the other check, yeah. A patch removing that should be applied already.

Where exactly? It's not fixed in Jonathan's fixes-togreg branch, at least.
Did you fixed it?

Best regards,
--
Hector Palacios
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux