On 18/01/13 09:31, Denis CIOCCA wrote:
Hi Lars, Jonathan,
I review the driver code in accordance with Lars's review. What do you think about kconfig?
Looking quickly at the library code, the kconfig is fine, but I'd expect
the i2c and spi bits to be built into the main module if they are
present. Right now unless I am reading it wrong they'll get built even
if the main module isn't.
For the drivers, the make file can be a simpler and easy to follow if we
put back some the Kconfig symbols you had before but just have them
hidden. Basically it moves all the logic into Kconfig and means the
resulting .config is easy to follow.
To my mind that would be a little simpler.
I have yet to share some part of driver code in the library!
Denis
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
