On 11/05/2012 03:48 PM, Lars Poeschel wrote: > From: Lars Poeschel <poeschel@xxxxxxxxxxx> > > This adds the mfd cell to use the adc part of the Nano River Technologies > viperboard. > > Signed-off-by: Lars Poeschel <poeschel@xxxxxxxxxxx> Looks good to me. Reviewed-by: Lars-Peter Clausen <lars@xxxxxxxxxx> If you happen to resend the series there is one tiny bit that could be changed, but no need to resend the series just for this. > --- > drivers/iio/adc/Kconfig | 7 ++ > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/viperboard_adc.c | 181 ++++++++++++++++++++++++++++++++++++++ > drivers/mfd/viperboard.c | 3 + > include/linux/mfd/viperboard.h | 1 + > 5 files changed, 193 insertions(+) > create mode 100644 drivers/iio/adc/viperboard_adc.c > > + > +static int __devinit vprbrd_adc_probe(struct platform_device *pdev) > +{ > + struct vprbrd *vb = dev_get_drvdata(pdev->dev.parent); > + struct vprbrd_adc *adc; > + struct iio_dev *indio_dev; > + int ret; > + > + /* registering iio */ > + indio_dev = iio_device_alloc(sizeof(struct vprbrd_adc)); sizeof(*adc) > + if (!indio_dev) { > + dev_err(&pdev->dev, "failed allocating iio device\n"); > + return -ENOMEM; > + } -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html