On 07/03/2012 08:30 AM, Lars-Peter Clausen wrote: > On 07/02/2012 11:43 PM, Peter Meerwald wrote: >> sensor has 4 channels (10-bit each, R/G/B and clear), sensitivity >> and gain is controlled in the driver by ext_info integration_time >> and CHAN_INFO_HARDWAREGAIN >> >> driver supports triggered buffer and IIO_CHAN_INFO_RAW to get the >> sensor data >> >> patch depends on IIO_MOD_LIGHT_RED etc, the patch providing that >> (http://permalink.gmane.org/gmane.linux.kernel.iio/4354) has not been >> merged yet, a new proposal is following >> >> v4: address comments by Lars-Peter Clausen >> * make sure trigger handler is exited with iio_trigger_notify_done() >> and IRQ_HANDLED >> * kfree()/kalloc() -> krealloc() >> >> v3: >> * fix warnings >> >> v2: address comments by Lars-Peter Clausen >> * buffer allocation now in update_scan_mode instead of in trigger >> handler >> * simplify trigger code (assume active_scan_mask is not empty, use >> for_each_set_bit, use iio_push_to_buffer) >> * reorder entry in Makefile and Kconfig >> * fix remove >> >> Signed-off-by: Peter Meerwald <pmeerw@xxxxxxxxxx> > > Looks good, > > Reviewed-by: Lars-Peter Clausen <lars@xxxxxxxxxx> Sorry Lars-Peter, I'd forgotten you'd done that for this earlier version so didn't add it to v5 when merging. Peter, if you make minor changes people 'normally' don't mind if you carry there acked-by etc on with it. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
