On Mon, Jan 30, 2012 at 9:28 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On 01/30/2012 08:22 PM, Mark Brown wrote:
>> On Sun, Jan 29, 2012 at 11:46:50AM +0000, Jonathan Cameron wrote:
>>
>>> + mutex_lock(&iio_map_list_lock); + while ((maps[i].consumer_dev
>>> != NULL) || + (maps[i].consumer_dev_name != NULL)) {
>>
>> I'd suggest just dropping the struct device - the reason we support
>> the struct device directly in the regulator API is that we
>> originally had only a struct device and kept the code around as a
>> transition measure (though now it's so old we should be able to
>> kill it off). This would simplify the code and the interface a
>> bit.
>
> Ah, that explains your comment on the 5th patch. Alright, I'll let this
> sit for a few days and if no one comes up with a good reason not to
> we'll go with just the dev_name option.
I've just deleted the yse of struct device * from the pin control
subsystem and I bet ark will have it deleted from regulator_consumer
before long, so just let it go :-)
Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
