Re: [PATCH 1/5] staging:iio:core add in kernel interface mapping and getting IIO channels.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 29, 2012 at 11:46:50AM +0000, Jonathan Cameron wrote:

> -static struct device_type iio_dev_type = {
> +struct device_type iio_dev_type = {
>  	.name = "iio_device",
>  	.release = iio_dev_release,
>  };

Why is this exported?

> +	mutex_lock(&iio_map_list_lock);
> +	while ((maps[i].consumer_dev != NULL) ||
> +	       (maps[i].consumer_dev_name != NULL)) {

I'd suggest just dropping the struct device - the reason we support the
struct device directly in the regulator API is that we originally had
only a struct device and kept the code around as a transition measure
(though now it's so old we should be able to kill it off).  This would
simplify the code and the interface a bit.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux