Looks sensible to me though obviously this is bit is really for the at91 lot to comment on. On 11/07/2011 04:08 PM, Maxime Ripard wrote: > Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxx> > Cc: Patrice Vilchez <patrice.vilchez@xxxxxxxxx> > Cc: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> Acked-by: Jonathan Cameron <jic23@xxxxxxxxx> > --- > arch/arm/mach-at91/include/mach/board.h | 18 ++++++++++++++++++ > 1 files changed, 18 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-at91/include/mach/board.h b/arch/arm/mach-at91/include/mach/board.h > index ed544a0..afdcac0 100644 > --- a/arch/arm/mach-at91/include/mach/board.h > +++ b/arch/arm/mach-at91/include/mach/board.h > @@ -207,4 +207,22 @@ extern void __init at91_pwm_leds(struct gpio_led *leds, int nr); > /* FIXME: this needs a better location, but gets stuff building again */ > extern int at91_suspend_entering_slow_clock(void); > > +/* ADC */ > +struct at91_adc_data { > + /* ADC Clock as specified by the datasheet, in Hz. */ > + unsigned int adc_clock; > + /* > + * Global number of channels available (to specify which channels are > + * indeed used on the board, see the channels_used array). > + */ > + u8 num_channels; > + /* Channels in use on the board */ One nitpick here. You could make it more obvious that this is a mask... > + unsigned long channels_used; > + /* Startup time of the ADC, in microseconds. */ > + u8 startup_time; > + /* Reference voltage for the ADC in millivolts */ > + unsigned short vref; > +}; > +extern void __init at91_add_device_adc(struct at91_adc_data *data); > + > #endif -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html