On 17:38 Thu 03 Nov , Linus Walleij wrote: > On Thu, Nov 3, 2011 at 5:27 PM, Maxime Ripard > <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > > [Me] > >> We're not supposed to have platform data dependent to stuff in > >> staging under arch/arm or anyplace else in the main kernel tree. > >> > >> Please move this to > >> drivers/staging/iio/adc/at91adc-board.h > >> or so. > > > > Won't moving this part to staging prevent from using this structure in > > board files ? If so, how will I be able to declare a new board that is > > using this ADC (or add the support for the ADC to a new one) ? > > Put this into a separate board file living under staging/iio/adc > > Compare: > drivers/staging/ste_rmi4/board-mop500-u8500uib-rmi4.c > > >> As for calling the at91_add_device_adc() function (which I guess > >> you want to do at some point) the pattern I followed for other > >> drivers is to declare a dummy function in arch/arm/mach-* > >> with __weak and let the staging driver override that. This way > >> the staging driver can go away without any compilation trouble > >> happening. > > > > I don't really see why my changes will break the compilation if the > > driver is no longer present in staging. At worst, the structure will be > > filled but used by no one, right ? > > You're right. > > But still, we cannot add that header file for a driver that > is in the staging tree. Header files go into the staging dir too. agreed Best Regards, J. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
