On 10/31/2011 12:28 PM, Jonathan Cameron wrote: > On 10/27/11 09:44, Lars-Peter Clausen wrote: >> This patch adds support for the Analog Devices AD5421 Loop-Powered, 4mA to 20mA >> DAC. >> >> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx> > Acked-by: Jonathan Cameron <jic23@xxxxxxxxx> > > Feel free to send on to Greg as you've nailed everything I cared about. > > I do wonder if we might be better with an explicit 'no_read' flag in the > chan_spec for channels like this. That way we could assign more meaningful > channel numbers? Afterall, sooner of later we are going to have something > with two temperature sensors that only generate events. > > What do you think? Makes sense, but I think we can add this when we have to add support for such a device. An alternative would be to make devices explicitly request raw attributes through info_mask. But that would require touching all existing drivers again. Could you also Ack "staging:iio: IIO_EVENT_CODE: Clamp channel numbers"? I'll replace the s16 with __s16 before sending it on to Greg. Thanks - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
